Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy: move c.compression* to imageCopier #1881

Merged
merged 1 commit into from
Mar 11, 2023
Merged

copy: move c.compression* to imageCopier #1881

merged 1 commit into from
Mar 11, 2023

Conversation

flouthoc
Copy link
Contributor

@flouthoc flouthoc commented Mar 10, 2023 •
edited
Loading

There may be needs to modify of selected compression for a single instance so allow setting compression to imageCopier which can be altered while operation is being performed on a single image.

Part of discussion here: #1875

@flouthoc
Copy link
Contributor Author

@mtrmac @giuseppe @vrothberg PTAL

mtrmac
mtrmac reviewed Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One more simplification…

copy/compression.go Outdated Show resolved Hide resolved
copy/single.go Outdated Show resolved Hide resolved
@flouthoc
copy: move c.compression* to imageCopier
4a01a1b 
There may be needs to modify of select compression for a single instance
so allow setting compression to imageCopier which can be altered while
operation is being performed on a single image.

Signed-off-by: Aditya R <arajan@redhat.com>
@flouthoc flouthoc force-pushed the move-compression-imagecopier branch from 3683358 to 4a01a1b Compare March 11, 2023 05:01
@flouthoc flouthoc requested a review from mtrmac March 11, 2023 05:55
giuseppe
giuseppe approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtrmac
mtrmac approved these changes Mar 11, 2023
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac mtrmac merged commit d12f543 into containers:main Mar 11, 2023
@mtrmac mtrmac mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac approved these changes

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flouthoc @giuseppe @mtrmac